[oe] [meta-oe][PATCH v7 6/7] opencv: Fix build on x86 platform

[Andre McCurdy]

On Fri, Apr 1, 2016 at 2:57 PM, Ricardo Ribalda Delgado
<ricardo.ribalda at gmail.com> wrote:
> Hi Andre
>
> += does not add the leading space?

It does. But the preferred way is not to combine _append and +=.
Therefore if you use _append, you should combine it with = and add the
leading space explicitly.

> http://www.yoctoproject.org/docs/2.0/bitbake-user-manual/bitbake-user-manual.html#appending-and-prepending-override-style-syntax
>
> I thought += was preferred.

Where does it say that?

> I am confused. What shall I resend += " foo" or = " foo" ?

Martin's comment (in reply to the v4 patch) was:

"Please don't combine _append and +=. _append and leading space in
value (as you already have) is enough."

The version you should use is:

EXTRA_OECMAKE_append_x86 = " -DX86=ON"


> Regards
>
> On Fri, Apr 1, 2016 at 11:46 PM, Andre McCurdy <armccurdy at gmail.com> wrote:
>> On Fri, Apr 1, 2016 at 2:36 PM, Ricardo Ribalda Delgado
>> <ricardo.ribalda at gmail.com> wrote:
>>> OpenCV wrongly assumes that the X86 variable would be set on Intel 32
>>> bit architectures.
>>>
>>> This patch adds the missing definition on those cases.
>>>
>>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda at gmail.com>
>>> ---
>>>  meta-oe/recipes-support/opencv/opencv_3.1.bb | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/meta-oe/recipes-support/opencv/opencv_3.1.bb b/meta-oe/recipes-support/opencv/opencv_3.1.bb
>>> index 63955a862d4a..b89fbbb214f6 100644
>>> --- a/meta-oe/recipes-support/opencv/opencv_3.1.bb
>>> +++ b/meta-oe/recipes-support/opencv/opencv_3.1.bb
>>> @@ -45,6 +45,7 @@ EXTRA_OECMAKE = "-DPYTHON2_NUMPY_INCLUDE_DIRS:PATH=${STAGING_LIBDIR}/${PYTHON_DI
>>>                   ${@base_conditional("libdir", "/usr/lib64", "-DLIB_SUFFIX=64", "", d)} \
>>>                   ${@base_conditional("libdir", "/usr/lib32", "-DLIB_SUFFIX=32", "", d)} \
>>>  "
>>> +EXTRA_OECMAKE_append_x86 = "-DX86=ON"
>>
>> That should be:
>>
>> EXTRA_OECMAKE_append_x86 = " -DX86=ON"
>>
>> Note the leading space. See:
>>
>>   http://www.yoctoproject.org/docs/2.0/bitbake-user-manual/bitbake-user-manual.html#appending-and-prepending-override-style-syntax
>>
>>>
>>>  PACKAGECONFIG ??= "eigen jpeg png tiff v4l libv4l gstreamer samples tbb \
>>>                     ${@bb.utils.contains("DISTRO_FEATURES", "x11", "gtk", "", d)} \
>>> --
>>> 2.8.0.rc3
>>>
>
>
>
> --
> Ricardo Ribalda