[oe] [PATCH] openssl : By default, disable cryptodev.

[Burton, Ross]

On 17 July 2017 at 02:54, Huang Qiyu <huangqy.fnst at cn.fujitsu.com> wrote:

> Because according to the other Distros(e.g. Ubuntu, Fedora), cryptodev is
> not enabled.
> If users want enable cryptodev, just have to add "cryptodev-linux" into
> PACKAGECONFIG.
>

Wrong list, you meant oe-core at .

There was a discussion about this back in March ("openssl: disable
cryptodev by default") where Wind River reports that they see a number of
customers using hardware crypto.  I'm all for making this an option but
whether to enable/disable it by default isn't clear.


-DEPENDS += "cryptodev-linux"
+PACKAGECONFIG[cryptodev-linux] = ",,cryptodev-linux"

Just call this cryptodev, imho.

+DEPENDS += "${@bb.utils.contains('PACKAGECONFIG', 'cryptodev-linux',
'cryptodev-linux', '', d)}"

No need to do this, as that is what the third option to the PACKAGECONFIG
flag is for.

+CFLAG += "${@bb.utils.contains('PACKAGECONFIG', 'cryptodev-linux',
'-DHAVE_CRYPTODEV -DUSE_CRYPTODEV_DIGESTS', '', d)}"

If you add those to the first value in the PACKAGECONFIG flag list then you
could just add PACKAGECONFIG_CONFARGS to CFLAG, and using PACKAGECONFIG for
other options in the future is then trivial.

Ross