[oe] [PATCH] openssl : By default, disable cryptodev.

[Huang, Qiyu]

Dear Ross

> There was a discussion about this back in March ("openssl: disable cryptodev by default") where Wind River reports that they see a number of customers using
> hardware crypto.  I'm all for making this an option but whether to enable/disable it by default isn't clear.

I'm sorry that I didn't notice that discussion. Really some users want to use hardware crypto, but for users who don't want to use cryptodev, they have to enable cryptodev.

I think my patch is a good solution. Disable cryptodev by default as the other popular Distros, and for users who want to use cryptodev, it is easy to enable it (Only have to add cryptodev into PACKAGECONFIG).

Thank for your sugguestion, and I'll modified my patch. If you decide to disable cryptodev by default, you can consider my patch.


From: Burton, Ross [mailto:ross.burton at intel.com]
Sent: Monday, July 17, 2017 6:22 PM
To: Huang, Qiyu/黄 琦宇 <huangqy.fnst at cn.fujitsu.com>
Cc: OpenEmbedded Devel List <openembedded-devel at lists.openembedded.org>; Bian, Yaqin/卞 亚琴 <bianyq at cn.fujitsu.com>
Subject: Re: [oe] [PATCH] openssl : By default, disable cryptodev.


On 17 July 2017 at 02:54, Huang Qiyu <huangqy.fnst at cn.fujitsu.com<mailto:huangqy.fnst at cn.fujitsu.com>> wrote:
Because according to the other Distros(e.g. Ubuntu, Fedora), cryptodev is not enabled.
If users want enable cryptodev, just have to add "cryptodev-linux" into PACKAGECONFIG.

Wrong list, you meant oe-core at .

There was a discussion about this back in March ("openssl: disable cryptodev by default") where Wind River reports that they see a number of customers using hardware crypto.  I'm all for making this an option but whether to enable/disable it by default isn't clear.


-DEPENDS += "cryptodev-linux"
+PACKAGECONFIG[cryptodev-linux] = ",,cryptodev-linux"

Just call this cryptodev, imho.

+DEPENDS += "${@bb.utils.contains('PACKAGECONFIG', 'cryptodev-linux', 'cryptodev-linux', '', d)}<mailto:$%7b at bb.utils.contains('PACKAGECONFIG',%20'cryptodev-linux',%20'cryptodev-linux',%20'',%20d)%7d>"

No need to do this, as that is what the third option to the PACKAGECONFIG flag is for.

+CFLAG += "${@bb.utils.contains('PACKAGECONFIG', 'cryptodev-linux', '-DHAVE_CRYPTODEV -DUSE_CRYPTODEV_DIGESTS', '', d)}<mailto:$%7b at bb.utils.contains('PACKAGECONFIG',%20'cryptodev-linux',%20'-DHAVE_CRYPTODEV%20-DUSE_CRYPTODEV_DIGESTS',%20'',%20d)%7d>"

If you add those to the first value in the PACKAGECONFIG flag list then you could just add PACKAGECONFIG_CONFARGS to CFLAG, and using PACKAGECONFIG for other options in the future is then trivial.

Ross