[oe] [PATCH] goarch.bbclass: Replace logic for setting GOARM

[Burton, Ross]

This class is in oe-core, so should go do openembedded-core@ not -devel at .

Ross

On 7 September 2017 at 10:20, Will Newton <will.newton at gmail.com> wrote:

> On Thu, Sep 7, 2017 at 10:18 AM, Martin Jansa <martin.jansa at gmail.com>
> wrote:
> > Wrong ML
>
> I appreciate you taking the time to craft this response, but it isn't
> very helpful to me.
>
> > On Thu, Sep 7, 2017 at 11:17 AM, Will Newton <will.newton at gmail.com>
> wrote:
> >>
> >> The previous logic applied a regex to TUNE_FEATURES which could
> >> set the GOARM value to 7 incorrectly, for example when dealing
> >> with an arm1176 core. Simplify to check for the presence of
> >> "armv7a" instead. At the same time add a check for "armv6" and
> >> set GOARM to 6 in that case.
> >>
> >> Signed-off-by: Will Newton <willn at resin.io>
> >> ---
> >>  meta/classes/goarch.bbclass | 7 +++++--
> >>  1 file changed, 5 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/meta/classes/goarch.bbclass b/meta/classes/goarch.bbclass
> >> index 4a5b2ec..35f2987 100644
> >> --- a/meta/classes/goarch.bbclass
> >> +++ b/meta/classes/goarch.bbclass
> >> @@ -38,8 +38,11 @@ def go_map_arch(a, d):
> >>
> >>  def go_map_arm(a, f, d):
> >>      import re
> >> -    if re.match('arm.*', a) and re.match('arm.*7.*', f):
> >> -        return '7'
> >> +    if re.match('arm.*', a):
> >> +        if 'armv7a' in f:
> >> +            return '7'
> >> +        elif 'armv6' in f:
> >> +            return '6'
> >>      return ''
> >>
> >>  def go_map_os(o, d):
> >> --
> >> 2.7.4
> >>
> >> --
> >> _______________________________________________
> >> Openembedded-devel mailing list
> >> Openembedded-devel at lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>