[oe] [meta-networking][PATCHv2] samba: Add packagegroup

[Khem Raj]

On 1/24/18 5:44 AM, Andreas Oberritter wrote:
> On Tue, 23 Jan 2018 23:25:11 -0600
> Khem Raj <raj.khem at gmail.com> wrote:
> 
>> On 1/23/18 5:58 PM, Andreas Oberritter wrote:
>>> On Tue, 23 Jan 2018 09:48:14 -0600
>>> Khem Raj <raj.khem at gmail.com> wrote:
>>>   
>>>> On Mon, Dec 11, 2017 at 8:21 AM, zhengrq <zhengrq.fnst at cn.fujitsu.com> wrote:  
>>>>> Add packagegroup for samba, for there are too many rpms in samba and it's hard to manage.
>>>>>
>>>>> Signed-off-by: Zheng Ruoqin <zhengrq.fnst at cn.fujitsu.com>
>>>>> ---
>>>>>  .../recipes-connectivity/samba/samba_4.6.7.bb         | 19 ++++++++++++++++++-
>>>>>  1 file changed, 18 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/meta-networking/recipes-connectivity/samba/samba_4.6.7.bb b/meta-networking/recipes-connectivity/samba/samba_4.6.7.bb
>>>>> index 2b227c9..0bacb02 100644
>>>>> --- a/meta-networking/recipes-connectivity/samba/samba_4.6.7.bb
>>>>> +++ b/meta-networking/recipes-connectivity/samba/samba_4.6.7.bb
>>>>> @@ -162,7 +162,7 @@ PACKAGES =+ "${PN}-python ${PN}-pidl \
>>>>>               ${PN}-dsdb-modules ${PN}-testsuite registry-tools \
>>>>>               winbind \
>>>>>               ${PN}-common ${PN}-base ${PN}-ctdb-tests \
>>>>> -             smbclient"
>>>>> +             smbclient ${PN}-client ${PN}-test"
>>>>>
>>>>>  python samba_populate_packages() {
>>>>>      def module_hook(file, pkg, pattern, format, basename):
>>>>> @@ -254,3 +254,20 @@ FILES_smbclient = "${bindir}/cifsdd \
>>>>>
>>>>>  RDEPENDS_${PN}-pidl_append = " perl"
>>>>>  FILES_${PN}-pidl = "${bindir}/pidl ${datadir}/perl5/Parse"
>>>>> +
>>>>> +SUMMARY_${PN}-client = "samba client"
>>>>> +RDEPENDS_${PN}-client = "\
>>>>> +    smbclient \
>>>>> +    winbind \
>>>>> +    registry-tools \
>>>>> +    ${PN}-pidl \
>>>>> +    "
>>>>> +
>>>>> +ALLOW_EMPTY_${PN}-client = "1"
>>>>> +
>>>>> +RDEPENDS_${PN}-test = "\
>>>>> +    ${PN}-ctdb-tests \
>>>>> +    ${PN}-testsuite \
>>>>> +    "
>>>>> +
>>>>> +ALLOW_EMPTY_${PN}-test = "1"    
>>>>
>>>> perhaps better to add a packagegroup recipe explicitly  
>>>
>>> How would a packagegroup be useful for a single recipe? We discussed this
>>> back in December:  
>>
>> why does single recipe matter ?
> 
> Because the most simple form of a group of packages is a meta package in the
> recipe creating the packages. And simple, in case of doubt, wins against
> complicated.
> 

Yes thats correct and usually, meta packages are a bit rare, where as
packagegroups are more or less self explanatory. If we are defining a
meta package, perhaps the package granularity of samba should also be
looked at, it might be too granular to be useful. Either way, I think
its fine, I personally prefer packagegroups