[oe] [meta-networking][PATCH] blueman: fix rdepends issue

[Martin Jansa]

On Wed, Nov 07, 2018 at 11:40:40AM -0800, akuster808 wrote:
> 
> On 11/7/18 11:22 AM, Andreas Müller wrote:
> > On Wed, Nov 7, 2018 at 8:12 PM Armin Kuster <akuster808 at gmail.com> wrote:
> >> fixes
> >> ERROR: Required build target 'blueman' has no buildable providers.
> >> Missing or unbuildable dependency chain was: ['blueman', 'thunar']
> >>
> >> Signed-off-by: Armin Kuster <akuster808 at gmail.com>
> >> ---
> >>  meta-networking/recipes-connectivity/blueman/blueman_git.bb | 5 +++--
> >>  1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/meta-networking/recipes-connectivity/blueman/blueman_git.bb b/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> >> index 8eb99ed..06a11b7 100644
> >> --- a/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> >> +++ b/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> >> @@ -27,9 +27,10 @@ RRECOMENDS_${PN} += "adwaita-icon-theme"
> >>  RDEPENDS_${PN} += " \
> >>      python3-dbus \
> >>      packagegroup-tools-bluetooth \
> >> +    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'thunar', '', d)} \
> >>  "
> >> -
> >> -PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,thunar"
> >> +PACKAGECONGIG ??= ""
> >> +PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,"
> >>
> >>  FILES_${PN} += " \
> >>      ${datadir}/dbus-1 \
> >> --
> >> 2.7.4
> >>
> > This is not right: How shall this happen if meta-xfce is not in your
> > layers - I suggest you run a cleansstate after changing layer
> > configuration
> 
> 
> I am running the yocto-check-layer.  Should this recipe really be in
> meta-xfce? .. I am out of options on how to get this to pass. Maybe no
> one cares if it ever does???

Isn't the error shown only with your addition to RDEPENDS? Because
without this patch the thunar dependency is enabled only when meta-xfce
layer is included with:

cat ./meta-xfce/recipes-connectivity/blueman/blueman_%.bbappend
PACKAGECONFIG_append = " thunar"

Why would blueman depend on thunar without meta-xfce?
And with both meta-networking and meta-xfce included it will find thunar
depdencency in meta-xfce.

But with your change you're adding thunar dependency whenever x11 is in
DISTRO_FEATURES with or without meta-xfce included which is clearly
wrong and yocto-check-layer would be correct to complain.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20181107/f5c39616/attachment-0002.sig>