[oe] [meta-networking][PATCH] blueman: fix rdepends issue

[Andreas Müller]

On Wed, Nov 7, 2018 at 9:44 PM Martin Jansa <martin.jansa at gmail.com> wrote:
>
> On Wed, Nov 07, 2018 at 11:40:40AM -0800, akuster808 wrote:
> >
> > On 11/7/18 11:22 AM, Andreas Müller wrote:
> > > On Wed, Nov 7, 2018 at 8:12 PM Armin Kuster <akuster808 at gmail.com> wrote:
> > >> fixes
> > >> ERROR: Required build target 'blueman' has no buildable providers.
> > >> Missing or unbuildable dependency chain was: ['blueman', 'thunar']
> > >>
> > >> Signed-off-by: Armin Kuster <akuster808 at gmail.com>
> > >> ---
> > >>  meta-networking/recipes-connectivity/blueman/blueman_git.bb | 5 +++--
> > >>  1 file changed, 3 insertions(+), 2 deletions(-)
> > >>
> > >> diff --git a/meta-networking/recipes-connectivity/blueman/blueman_git.bb b/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> > >> index 8eb99ed..06a11b7 100644
> > >> --- a/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> > >> +++ b/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> > >> @@ -27,9 +27,10 @@ RRECOMENDS_${PN} += "adwaita-icon-theme"
> > >>  RDEPENDS_${PN} += " \
> > >>      python3-dbus \
> > >>      packagegroup-tools-bluetooth \
> > >> +    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'thunar', '', d)} \
> > >>  "
> > >> -
> > >> -PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,thunar"
> > >> +PACKAGECONGIG ??= ""
> > >> +PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,"
> > >>
> > >>  FILES_${PN} += " \
> > >>      ${datadir}/dbus-1 \
> > >> --
> > >> 2.7.4
> > >>
> > > This is not right: How shall this happen if meta-xfce is not in your
> > > layers - I suggest you run a cleansstate after changing layer
> > > configuration
> >
> >
> > I am running the yocto-check-layer.  Should this recipe really be in
> > meta-xfce? .. I am out of options on how to get this to pass. Maybe no
> > one cares if it ever does???
>
> Isn't the error shown only with your addition to RDEPENDS? Because
> without this patch the thunar dependency is enabled only when meta-xfce
> layer is included with:
>
> cat ./meta-xfce/recipes-connectivity/blueman/blueman_%.bbappend
> PACKAGECONFIG_append = " thunar"
>
> Why would blueman depend on thunar without meta-xfce?
> And with both meta-networking and meta-xfce included it will find thunar
> depdencency in meta-xfce.
>
> But with your change you're adding thunar dependency whenever x11 is in
> DISTRO_FEATURES with or without meta-xfce included which is clearly
> wrong and yocto-check-layer would be correct to complain.
>
My opinion as author and user of blueman recipe: The patch sent is
wrong. It breaks blueman's thunar-sendto-blueman.desktop in case
thunar is not in the image and I cannot see what's wrong with current
layout.

For me this is yet another example of wasting time for the sake of
yocto-layer-script.  Correct answer should have been: 'Go fix that
script' but that certainly would have caused further discussion. So I
agreed the suggestion to move blueman to meta-xfce. This makes holy
marketing script happy, matches my used-case and I can continue with
useful things.

Regards

Andreas