[oe] mtn disapprove d7758e2637918ff4035244d64fb7227f6cf833ad, was Re: [oe-commits] org.oe.dev phoneserver: Add patch for FIC GTA01 support.

[Philippe De Swert]

Hi,

On Wed, 2007-07-25 at 13:04 +0200, Florian Boor wrote:
> Hi,
> 
> Koen Kooi schrieb:
> > You are right that it's more productive to fix small errors than to disapprove, but:
> > I did that the first few times with PACKAGE_ARCH = "${MACHINE}", and people still keep
> > adding it, so now I'm doing dissaprove + mail to oe-devel to raise awareness.
> > Fixing errors afterwards is only productive if people learn from it and stop making the
> > same error again, which wasn't the case here.
> 
> didn't I react on the mail to the list?
> Did I introduce a similar bug lately?
> 
> I really do not appreciate if people revert a complete change for the lack of
> five bytes. That wastes too much of precious time - I can live with that, but I
> do not want such reactions causing other contributors to run away.

I tend to agree with Florian here. However the first time you need to
fix it mail the person who made the mistake and cc the mailing list so
everybody knows. Only afterwards you can start disapproving commits.

Cheers,

Philippe