[oe] Revert + apologies (was: Re: [oe-commits] Frans Meulenbroeks : lsof/lsof_4.83.bb: removed unneeded EXTRA_OEMAKE)

[Andrea Adami]

Frans,

nerverthless some recipes of the group *did* build flawlessy after
removing the EXTRA_OEMAKE.

ifupdown/ifupdown_0.6.10.bb
ifupdown/ifupdown-ubuntu_0.6.8.bb
man-pages/man-pages_3.21.bb

I tested only a few...probably others too.

It looks to me this was a quick hack to make broken recipes build...

Anyway, thank again for your work. Keep on!

Andrea

On Mon, Oct 25, 2010 at 8:45 AM, Frans Meulenbroeks
<fransmeulenbroeks at gmail.com> wrote:
> 2010/10/25 Andrea Adami <andrea.adami at gmail.com>:
>> build breaks on do_compile after that commit
>>
>> Needs investigation
>>
>> Andrea
>
> Oops.
> Apparently this was not well enough tested. My sincere apologies!
> I've reverted all the patches that removed EXTRA_OEMAKE = "".
>
> What happened was that I was being told on irc that comparing the
> output from bitbake -e before and after making the change was
> sufficient.
> I've tested one recipe more in-depth and that worked fine, then
> further relied upon comparing the bitbake -e results.
> This proved to be a sound method when dealing with EXTRA_OECONF.
> Apparently however it was not good enough for EXTRA_OEMAKE and some if
> not most recipes are not in my regular build (definitely the older
> versions are not).
>
> I'll try to peek into this later. Anyway, again my apologies for any
> inconvenience caused and thanks to Andrea for reporting this!
>
> Best regards, Frans
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>