[oe] `PR = "r0"`: Add or not to add?
Koen Kooi
koen at dominion.thruhere.net
Wed Aug 31 12:45:22 UTC 2011
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Op 31-08-11 14:34, Otavio Salvador schreef:
> On Wed, Aug 31, 2011 at 09:16, Koen Kooi <koen at dominion.thruhere.net>
> wrote:
>>>>>> please remove PR in new recipes
>>>>> Actually I would favor to leave them in.
>>>> Well I don't, and atm I decide if it goes in or not.
>>>
>>> To sad. It's a lot easier to remember to bump the PR, when PR
>>> actually is in the recipe. Thus, including PR=0 will often remove one
>>> issue with patches.
>>
>> That's what review is for, no?
>
> Review is to check for mistakes and dropping PR from new recipes just
> makes hard for new users and put more work for people to review.
>
> Please accept PR = "r0" on new recipes since it makes it more consistent
> and easy to new users.
Consistent in what way? If you want to be consistent you need to add *all*
variables to the recipe and set it to their default.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFOXiziMkyGM64RGpERArVFAJ9XOjQIEyuO2O170XTAlyduOxMYYwCeOXzk
oxzHXdyhx78QoZZOu/owDUU=
=J5Ow
-----END PGP SIGNATURE-----
More information about the Openembedded-devel
mailing list